Ethan Davidson's picture

Ethan Davidson made 39 contributions in release v1.0 !

Chief Scientist, Founder @FartLabs 🧪 Previously @google ✨ Alum @acmcsufoss #🟦
  1. #4 Added Samuel's Changes
    1 commit (expand)
    1. Added Samuel's Changes
  2. #21 Updated call-to-action component to new design
    2 commits (expand)
    1. Revert "Revert "Updated design of hero.svelte! ⚔"" This reverts commit f3d634321770af75805ca0ca0e27690acb63d112.
    2. Updated call-to-action component to new design.
  3. #22 Update navbar.svelte
    1 commit (expand)
    1. Update navbar.svelte Updated navbar to match the new design. This code was adapted from @mikeploythai's proof-of-concept CSS.
  4. #23 Update browser tab title to say `"acmCSUF | ACM at CSUF"`.
    1 commit (expand)
    1. Update _layout.svelte
  5. #37 Created `common-hero.svelte`
    3 commits (expand)
    1. Created `common-hero.svelte` I created the common-hero component and applied it to the about page. Soon, let's apply it to the other subpages.
    2. Update common-hero.svelte Changed object tag to image tag instead.
    3. Update common-hero.svelte Typo 😐
  6. #38 Created the `officer-profile.svelte` component.
    1 commit (expand)
    1. Created the `officer-profile.svelte` component. I created the component and implemented it in the about page.
  7. #39 Created ARCHITECTURE.md and updated some documents.
    1 commit (expand)
    1. Created ARCHITECTURE.md and updated some documents.
  8. #40 Created the why-join component
    3 commits (expand)
    1. Created the why-join component Lookin good 😎
    2. Merge branch 'main' into ethan
    3. Eliminated unnecessary comments
  9. #42 Added the `acm-paths.svelte` section
    3 commits (expand)
    1. Update index.svelte
    2. Re-added CommonHero and WhyJoin components
    3. Created the acm-paths.svelte section! 🎉
  10. #43 Created the `officer-profile-list.svelte` component and more.
    1 commit (expand)
    1. Created the `officer-profile-list.svelte` component and more. I created the necessary `officer-profile-list.svelte` as well as the `acm-select.svelte` UI component to go with it.
  11. #46 Created `nodebuds-testimonial.svelte`
    1 commit (expand)
    1. Created `nodebuds-testimonial.svelte`
  12. #60 Meeting with Designer
    1 commit (expand)
    1. Meeting with Designer The changes in this commit are the result of the notes of a meeting with the site's designer. ## Structural Changes For component sections of the index page that are not used anywhere besides the index page have been moved to a new directory, `/src/components/index`. This includes `acm-paths.svelte`, `hero.svelte`, and `why-join.svelte`. For the NodeBuds page, some unique section components were also moved into a new directory, `/src/components/nodebuds`. This includes `nodebuds-testimonial.svelte` and `why-join-nodebuds.svelte`. Take note that I also changed the URL of the NodeBuds endpoint from `node-buds` to `nodebuds` since it is written as one word. Additionally, the `src/components/ui` directory has been renamed to `src/components/utils`. ## Stylistic Changes New variables have been added to the `global.css` file! The following variables have to do with the `font-size` style property and are intended to be used everywhere throughout the site. ```css :root { --heading-font-size: 48px; --subheading-font-size: 24px; --body-font-size: 18px; --margin-text-font-size: 12px; } @media screen and (min-width: 768px) { :root { --title-font-size: 96px; --heading-font-size: 64px; --subheading-font-size: 36px; --body-font-size: 24px; --margin-text-font-size: 16px; } } ``` The values that the variables are set to outside of the media query are the values used in mobile mode. The values set inside of the media query are the values used in tablet/desktop mode. In a number of files that are used on the index page, any unnecessary padding has been eliminated in favor of the `Spacing` component. This change contributes to issue #56, but does not complete it. Also, all of the instances on the index page where some sort of max-width is used (as a constraint to help with the page's layout) were replaced with margins instead.
  13. #64 Added `SkipNavbarContent` component for all pages.
    1 commit (expand)
    1. Added `SkipNavbarContent` component for all pages. I added this `SkipNavbarContent` component (essentially an extension of the `Spacing` component) so that every page has uniform, initial spacing.
  14. #65 Getting some final touches in before launching `/nodebuds`!
    3 commits (expand)
    1. Update nodebuds-testimonial.svelte
    2. Update why-join-nodebuds.svelte
    3. Added `/nodebuds` link to site menu.
  15. #70 Added red coloring to the nodebuds link on the site menu 🎨
    1 commit (expand)
    1. Update navbar.svelte
  16. #77 Moved all SVG data from `social-media-links.svelte` component into `/src/components/icons` directory.
    1 commit (expand)
    1. Moved all SVG data from `social-media-links.svelte` component into `/src/components/icons` directory. Yes, I did as the title reads.
  17. #79 Added some spacing on the `/about` page and `/paths` page.
    2 commits (expand)
    1. Update paths.svelte
    2. Update about.svelte
  18. #80 Fixed broken links to `/paths` page.
    1 commit (expand)
    1. Update paths.svelte
  19. #84 Added Google Form option for the `/connect` page
    3 commits (expand)
    1. Update get-in-touch-form.svelte Added `googleFormUrl` as a property to switch between an embedded Google form or the HTML implementation.
    2. Added Google form to connect page I added the Google form to the `/connect` page and added some final touches to prepare for the launch of the connect page for meeting #76! 🎉
    3. Updated property name to be an ID instead of a URL This way, the component can construct the correct URL on its own without relying on the property's value to get the proper URL.
  20. #85 Fixed up the hero image's weird spacing on mobile
    1 commit (expand)
    1. Update hero.svelte I removed the `
      ` element that was wrapping the image. This might have been the cause of the odd spacing shown on my mobile device. I will push these changes in order for Vercel to generate a preview for me to check on my mobile device.
  21. #86 Removed all unused assets and files 🚮
    2 commits (expand)
    1. Removed all unused assets and files. I double-checked, and all launched pages are not missing any images.
    2. Delete BOILERPLATE.md
  22. #87 Launch of `/connect` route 🙌
    2 commits (expand)
    1. Update social-media-links.svelte Fixed the icon fill color on hover for the social media links.
    2. Update navbar.svelte Added the connect link to the navbar.
  23. #91 Event Page Progress 🏔
    9 commits (expand)
    1. Here is a rough draft for adding the iCal data to the `/event` page. I added a new helper function to parse the text data into a list of formatted event interfaces to be read by the Svelte component. This is the beginning of tackling issue #75.
    2. Update parse-ical-data.ts Fixed indentation typo.
    3. Refactored the parsing algorithm Sorted, formatted, and filtered the AcmEvent objects.
    4. Initial work on the `/events` page 😎 We created the layout for the `/events` page and rendered the ICAL data from the Google Calendar. We also fixed some styles that conflicted with the event card that originated in the `call-to-action.svelte` component, so we added those fixes where needed.
    5. Merge branch 'main' into feature/event-page-preload
    6. Update event-item.svelte
    7. Implemented scrolling the carousel via grabbing ✊ When the user clicks and moves their cursor along the event carousel component, the scroll offset will automatically increment. Below is an emoji diagram of the expected gesture. ``` 🖐✊➡🖐 ```
    8. Refactored `grabbing` attribute into CSS class. Instead of reading the DIV's attributes to handle the grabbing state, I moved it into a variable `isGrabbing` to make the code cleaner. Suggested from:
    9. Merge branch 'main' into feature/event-page-preload
  24. #93 Updated the architecture and contribution documents.
    5 commits (expand)
    1. Updated the architecture and contribution documents. Updated the architecture and contribution documents.
    2. Update ARCHITECTURE.md Appended `/` to each directory name.
    3. Update ARCHITECTURE.md Appended `/` to all instances of directory names.
    4. Move documentation out from `/docs/` directory and into the root of the project.
    5. Changed all relative links in the newly-moved documentation files.
  25. #94 Removed more unused files.
    1 commit (expand)
    1. Removed more unused files
  26. #96 Created `path-section.svelte` component and implemented in `/paths` route
    3 commits (expand)
    1. Translated paths.svelte SCSS to CSS After converting there is one bug that I can see: the title of each path section is horizontally aligned when they are supposed to stack vertically.
    2. Created `path-section.svelte` to aide in rewriting the the `/paths` route. Created a new component, `path-section.svelte`, and used it in the `/paths` route for each acmCSUF path.
    3. Update path-section.svelte
  27. #97 Revert "Event Page Progress 🏔"
    1 commit (expand)
    1. Revert "Event Page Progress 🏔"
  28. #98 Bye, SCSS 👋
    15 commits (expand)
    1. Translated paths.svelte SCSS to CSS After converting there is one bug that I can see: the title of each path section is horizontally aligned when they are supposed to stack vertically.
    2. Created `path-section.svelte` to aide in rewriting the the `/paths` route. Created a new component, `path-section.svelte`, and used it in the `/paths` route for each acmCSUF path.
    3. No need for these files any longer. Removed useless SCSS files and unused Svelte components containing legacy SCSS styles.
    4. Translated paths.svelte SCSS to CSS After converting there is one bug that I can see: the title of each path section is horizontally aligned when they are supposed to stack vertically.
    5. Created `path-section.svelte` to aide in rewriting the the `/paths` route. Created a new component, `path-section.svelte`, and used it in the `/paths` route for each acmCSUF path.
    6. No need for these files any longer. Removed useless SCSS files and unused Svelte components containing legacy SCSS styles.
    7. Merge branch 'fix/remove-scss' of https://github.com/EthanThatOneKid/acmcsuf.com into fix/remove-scss
    8. Revert "Revert "Event Page Progress 🏔""
    9. Merge pull request #100 from EthanThatOneKid/revert-97-revert-91-feature/event-page-preload Revert "Revert "Event Page Progress 🏔""
    10. Update path-section.svelte
    11. Merge pull request #96 from EthanThatOneKid/fix/paths-page-to-css Created `path-section.svelte` component and implemented in `/paths` route. I am going ahead and merging this pull request. Closing #78.
    12. Update path-section.svelte
    13. No need for these files any longer. Removed useless SCSS files and unused Svelte components containing legacy SCSS styles.
    14. Merge branch 'fix/remove-scss' of https://github.com/EthanThatOneKid/acmcsuf.com into fix/remove-scss
    15. Removed SCSS-related (and unused) NPM dependencies.
  29. #100 Revert "Revert "Event Page Progress 🏔""
    1 commit (expand)
    1. Revert "Revert "Event Page Progress 🏔""
  30. #103 Fix our contact Google Form's height 📐
    1 commit (expand)
    1. Update get-in-touch-form.svelte
  31. #104 Launch of `/events` route! 🎉
    13 commits (expand)
    1. Copy event URL implemented 🔗 Created algorithm to make unique event fragments to be copied from the title of each event item. Each event gets its own, unique fragment that can be copied and linked to.
    2. Add Carousel Button Functionality Hide standard scrollbar on carousel. Added custom Horizontal Scroll Button to carousel. Add linear gradient effect to edge of carousel. Hide Scroll buttons on mobile view.
    3. Merge pull request #102 from bjwarfield/launch/events-route Add Carousel Button Functionality
    4. Update event-carousel.svelte Inspired by @bjwarfield's changes, I took it upon myself to refactor the code. There is always more room for improvement, so future changes are definitely encouraged.
    5. Updated event link generator Resolves comment .
    6. Highlight selected event
    7. Final touches to the /events route 🎉 We fixed some bugs before launching the events route. - Offset for the link when an event's fragment is included in the URL. - Fixed the "margins" for the event carousel. - Added a popover for copying the event URL. - Broke: Grabbing icon when grabbing the event carousel (it works some of the time).
    8. Update event-item.svelte
    9. Updated the border and box shadow color to acm-red.
    10. Update event-item.svelte Updated the color of the outline and box shadow of the highlighted event.
    11. Merge branch 'launch/events-route-target' into launch/events-route
    12. Launching the /events route Now, the navbar has a link to the /events route, so it will be included in the production site!
    13. Update events.svelte If an error occurs, just say that there are no events.
  32. #105 Serving iCal data for client to fetch on page load
    20 commits (expand)
    1. Copy event URL implemented 🔗 Created algorithm to make unique event fragments to be copied from the title of each event item. Each event gets its own, unique fragment that can be copied and linked to.
    2. Add Carousel Button Functionality Hide standard scrollbar on carousel. Added custom Horizontal Scroll Button to carousel. Add linear gradient effect to edge of carousel. Hide Scroll buttons on mobile view.
    3. Merge pull request #102 from bjwarfield/launch/events-route Add Carousel Button Functionality
    4. Update event-carousel.svelte Inspired by @bjwarfield's changes, I took it upon myself to refactor the code. There is always more room for improvement, so future changes are definitely encouraged.
    5. Updated event link generator Resolves comment .
    6. Highlight selected event
    7. Final touches to the /events route 🎉 We fixed some bugs before launching the events route. - Offset for the link when an event's fragment is included in the URL. - Fixed the "margins" for the event carousel. - Added a popover for copying the event URL. - Broke: Grabbing icon when grabbing the event carousel (it works some of the time).
    8. Update event-item.svelte
    9. Updated the border and box shadow color to acm-red.
    10. Update event-item.svelte Updated the color of the outline and box shadow of the highlighted event.
    11. Merge branch 'launch/events-route-target' into launch/events-route
    12. Launching the /events route Now, the navbar has a link to the /events route, so it will be included in the production site!
    13. Attempting to lazy load the ICAL data instead of render it server side.
    14. Update events.svelte If an error occurs, just say that there are no events.
    15. Added public API route for event data.
    16. Merge branch 'launch/events-route' into fix/events-route-lazy-load
    17. Added node-fetch to the dependencies.
    18. Update events.svelte Forget to uncomment something.
    19. Added configurations to run the server on Vercel.
    20. Added an isLoading message Added an isLoading feature so that the user is not confused by the "There are currently no events scheduled." message while they wait for the data to load. I wanted to use this [await block](https://svelte.dev/docs#await), but it felt right to just leave the loading in the `onMount` callback.
  33. #106 Fixed event highlight feature ⚡
    2 commits (expand)
    1. Fixed event highlight feature ⚡ I did so by adding a little bit of JavaScript to make it so that the element can toggle an `active` class to target the proper styles.
    2. Update event-item.svelte Improved the automatic scrolling effect of the targeted event.
  34. #107 Made grammar/word-choice updates 🎓
    6 commits (expand)
    1. Made grammar/word-choice updates on all text shown throughout the site. Here is my best effort as far as professional language and word-choice goes. Please feel free to suggest alternative wordings or grammar corrections.
    2. Addressing review @diamondburned's initial review of this branch Addressing review .
    3. Update event-carousel.svelte Capitalized "T" in "this".
    4. Adjusted all of the upper/lowercasing of all heading elements. In every page, I made sure that the capitalization was as intended.
    5. Merge branch 'main' into fix/grammar-overhaul
    6. Removed duplicate officer instances on about page.
  35. #108 Updating several 2020 officer images, descriptions, and titles...
    6 commits (expand)
    1. Updated several officer images, descriptions, and titles - Added spacing to the Officer Profile List component. - Created simple text colorizer for specific keywords in the Officer Profile component.
    2. Renamed Samuel Sandoval's title
    3. Update officers.ts
    4. Merge branch 'main' into fix/2020-officer-updates
    5. Updated Andrew's picture
    6. Merge branch 'fix/2020-officer-updates' of https://github.com/EthanThatOneKid/acmcsuf.com into fix/2020-officer-updates
  36. #111 Updated `acm-button.svelte` component styling
    2 commits (expand)
    1. Updated `acm-button.svelte` component styling
    2. Update acm-button.svelte Addressed @diamondburned's comment, .
  37. #112 Added a GitHub link 👨‍💻
    2 commits (expand)
    1. Added a GitHub link I added a GitHub icon on the bottom right of the footer that links to the site's GitHub repository. This icon disappears on mobile since it does not fit horizontally on the footer when the screen gets smaller.
    2. Moved link to relevant variable I moved the actually link URL into `/src/lib/links.ts` and imported it into the footer component.
  38. #113 Added "wheel" event to the carousel ♿
    3 commits (expand)
    1. Update event-carousel.svelte Added "wheel" event to the carousel.
    2. Replaced `onMount` with `on:` 🧠 For some reason, I completely forgot about the `on:` element directive in Svelte. Using this syntax, I can eliminate the need of `onMount` in order to subscribe event listeners to the DOM.
    3. Fixed typo "left" -> "right" Resolving typo addressed in .
  39. #119 Added `urlShortener` middleware ✨
    1 commit (expand)
    1. Added `urlShortener` middleware ✨ Now, whenever a specific slug is matched in the URL, the user is redirected to another URL.

Select a different release: